Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add secure MessageBus capability #816

Merged
merged 4 commits into from
May 7, 2021

Conversation

lenny-goodell
Copy link
Member

The PR is dependent on edgexfoundry/go-mod-bootstrap#225

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

General secure MessageBus capability does not exists

Issue Number: #598

What is the new behavior?

General secure MessageBus capability now exists

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any new imports or modules? If so, what are they used for and why?

no

Are there any specific instructions or things that should be known prior to reviewing?

Other information

Copy link
Contributor

@jim-wang-intel jim-wang-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny change suggestion

internal/trigger/messagebus/messaging.go Outdated Show resolved Hide resolved
pkg/secure/mqttfactory.go Outdated Show resolved Hide resolved
jim-wang-intel
jim-wang-intel previously approved these changes May 6, 2021
Copy link
Contributor

@jim-wang-intel jim-wang-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

AlexCuse
AlexCuse previously approved these changes May 6, 2021
@lenny-goodell lenny-goodell dismissed stale reviews from AlexCuse and jim-wang-intel via 568cb97 May 7, 2021 18:01
@lenny-goodell lenny-goodell force-pushed the secure-bus branch 4 times, most recently from 28e3018 to 7f384aa Compare May 7, 2021 18:41
@lenny-goodell lenny-goodell force-pushed the secure-bus branch 2 times, most recently from adc74fd to 451ea15 Compare May 7, 2021 20:15
Copy link
Contributor

@jim-wang-intel jim-wang-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (again) ;-)

@lenny-goodell lenny-goodell merged commit 3b42cf3 into edgexfoundry:master May 7, 2021
@lenny-goodell lenny-goodell deleted the secure-bus branch May 7, 2021 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Secure MessageBus Connection (App SDK)
3 participants