fix: Fix webserver to use ServerBindAddr only if not blank as rest of EdgeX #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenny-goodell
force-pushed
the
ListenAndServe
branch
from
95cadb9 to
ef21f22
Compare
|
recheck |
… EdgeX Services closes #775 BREAKING CHANGE: Webserver will be locked down to listen just to `Host` value when If `ServerBindAddr ` is blank Signed-off-by: lenny <[email protected]>
lenny-goodell
force-pushed
the
ListenAndServe
branch
from
ef21f22 to
af5bee8
Compare
lenny-goodell
changed the title
jim-wang-intel
approved these changes
Mar 31, 2021
Codecov Report
@@ Coverage Diff @@
## master #776 +/- ##
==========================================
- Coverage 63.13% 63.03% -0.10%
==========================================
Files 31 31
Lines 1972 1975 +3
==========================================
Hits 1245 1245
- Misses 642 645 +3
Partials 85 85
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
If
IfServerBindAddris blank, webserver listens to any interface rather than locked down to value of Host as with all other EdgeX services.is blank, webserver listens to any interface rather than locked down to value of Host as with all other EdgeX services.Issue Number: #775
What is the new behavior?
If
ServerBindAddris blank, webserver listens to value of Host as with all other EdgeX services.Does this PR introduce a breaking change?
BREAKING CHANGE: Webserver will be locked down to listen just to
Hostvalue when IfServerBindAddris blankAre there any new imports or modules? If so, what are they used for and why?
no
Are there any specific instructions or things that should be known prior to reviewing?
Other information