refactor: Remove deprecated environment variables and related code #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 25, 2021 13:23
This name matches the corresponding Binding type of `external-mqtt` closes #673 BREAKING CHANGE: Configuration section name changed Signed-off-by: lenny <[email protected]>
closes #337 BREAKING CHANGE: The following environment variables no longer supported: - `edgex_profile` (replaced by uppercase version) - `edgex_service` Signed-off-by: lenny <[email protected]>
lenny-goodell
force-pushed
the
deprecated
branch
from
1779dca to
e44cd7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Code contains deprecated environment variables highlighted with
TODO: Remove for release v2.0.0Issue Number: #337
What is the new behavior?
Deprecated environment variables and related code have been removed
Does this PR introduce a breaking change?
BREAKING CHANGE: The following environment variables no longer supported:
edgex_profile(replaced by uppercase version)edgex_serviceAre there any new imports or modules? If so, what are they used for and why?
no
Are there any specific instructions or things that should be known prior to reviewing?
Other information