Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger Factory - Inconsistent Returns #698

Closed
AlexCuse opened this issue Feb 16, 2021 · 0 comments · Fixed by #699
Closed

Trigger Factory - Inconsistent Returns #698

AlexCuse opened this issue Feb 16, 2021 · 0 comments · Fixed by #699
Assignees
Labels
3-high priority denoting release-blocking issues bug Something isn't working
Milestone

Comments

@AlexCuse
Copy link
Contributor

If no trigger matching configured name is found an error is logged, nil trigger is returned and handled by the SDK.

If an error is encountered when intiializing a custom trigger, an error is logged before panicking. I think in case of these errors it makes sense to force returning nil (even if the function returned a trigger and an error) and let the SDK handle it like it would any other nil trigger situation.

@lenny-goodell lenny-goodell added this to the Ireland milestone Feb 16, 2021
@lenny-goodell lenny-goodell added 3-high priority denoting release-blocking issues bug Something isn't working labels Feb 16, 2021
@lenny-goodell lenny-goodell linked a pull request Feb 16, 2021 that will close this issue
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3-high priority denoting release-blocking issues bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants