Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Upgrade to go-mod-messaging with ZMQ fix for Hanoi #660

Merged
merged 1 commit into from
Jan 26, 2021

Conversation

lenny-goodell
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Previous version of go-mod-messaging used older version of ZMQ module that has system call interrupt bug.
edgexfoundry/go-mod-messaging#76

Issue Number: #652

What is the new behavior?

Hanoi branch now uses go-mod-messaging that uses new version of ZQM module that has fix the bug

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any new imports or modules? If so, what are they used for and why?

no

Are there any specific instructions or things that should be known prior to reviewing?

Other information

@lenny-goodell lenny-goodell linked an issue Jan 26, 2021 that may be closed by this pull request
@codecov-io
Copy link

Codecov Report

Merging #660 (da4ff35) into hanoi (a22ec22) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            hanoi     #660   +/-   ##
=======================================
  Coverage   61.00%   61.00%           
=======================================
  Files          42       42           
  Lines        2208     2208           
=======================================
  Hits         1347     1347           
  Misses        773      773           
  Partials       88       88           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a22ec22...da4ff35. Read the comment docs.

@lenny-goodell lenny-goodell merged commit eab384c into edgexfoundry:hanoi Jan 26, 2021
@lenny-goodell lenny-goodell deleted the hanoi-zmq-fix branch January 26, 2021 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SDK: Update Hanoi branch with ZMQ fixed go-mod-messaging.
3 participants