Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: standardize dockerfiles #610

Merged
merged 2 commits into from
Dec 17, 2020
Merged

ci: standardize dockerfiles #610

merged 2 commits into from
Dec 17, 2020

Conversation

ernestojeda
Copy link
Contributor

  • use alpine 3.12
  • common apk add where possible
  • update copyright header where possible

Signed-off-by: Ernesto Ojeda [email protected]

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #609

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any new imports or modules? If so, what are they used for and why?

No

Are there any specific instructions or things that should be known prior to reviewing?

Other information

@ernestojeda
ci: standardize dockerfiles
cf51aae 
- [x] use alpine 3.12
- [x] common `apk add` where possible
- [x] update copyright header where possible

Signed-off-by: Ernesto Ojeda <[email protected]>
@ernestojeda ernestojeda requested review from lenny-goodell, soda480, jamesrgregg and bill-mahoney and removed request for lenny-goodell December 17, 2020 18:38
@ernestojeda ernestojeda self-assigned this Dec 17, 2020
@ernestojeda ernestojeda added enhancement New feature or request ireland labels Dec 17, 2020
@ernestojeda ernestojeda linked an issue Dec 17, 2020 that may be closed by this pull request
EdgeX DevOps: General Dockerfile Standardization #609
Closed
@ernestojeda ernestojeda added ci issue_type denoting non-code changes such as testing or compilation and removed enhancement New feature or request labels Dec 17, 2020
soda480
soda480 approved these changes Dec 17, 2020
View reviewed changes
Copy link
Contributor

@soda480 soda480 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell lenny-goodell merged commit 6d0fca7 into edgexfoundry:master Dec 17, 2020
@ernestojeda ernestojeda deleted the devops-std-dockerfiles branch September 20, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lenny-goodell lenny-goodell lenny-goodell approved these changes

@soda480 soda480 soda480 approved these changes

@jamesrgregg jamesrgregg Awaiting requested review from jamesrgregg

@bill-mahoney bill-mahoney Awaiting requested review from bill-mahoney

Assignees

@ernestojeda ernestojeda

Labels
ci issue_type denoting non-code changes such as testing or compilation ireland
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EdgeX DevOps: General Dockerfile Standardization
3 participants
@ernestojeda @soda480 @lenny-goodell