-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Replace calling NewBaseResponseWithoutMessage with NewBaseResponse #557
refactor: Replace calling NewBaseResponseWithoutMessage with NewBaseResponse #557
Conversation
…esponse NewBaseResponseWithoutMessage has been removed from go-mod-core-contracts close#556 Signed-off-by: lenny <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #557 +/- ##
==========================================
- Coverage 64.65% 60.97% -3.69%
==========================================
Files 35 42 +7
Lines 2105 2196 +91
==========================================
- Hits 1361 1339 -22
- Misses 663 770 +107
- Partials 81 87 +6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Includes capability to watch a section of the custom configuration for changes when using the Configuration Provider closes #557 & #578 Signed-off-by: lenny <[email protected]>
Includes capability to watch a section of the custom configuration for changes when using the Configuration Provider closes #557 & #578 Signed-off-by: lenny <[email protected]>
Includes capability to watch a section of the custom configuration for changes when using the Configuration Provider closes #557 & #578 Signed-off-by: lenny <[email protected]>
Includes capability to watch a section of the custom configuration for changes when using the Configuration Provider closes #557 & #578 Signed-off-by: lenny <[email protected]>
* feat: Add custom structured configuration capability Includes capability to watch a section of the custom configuration for changes when using the Configuration Provider closes #557 & #578 Signed-off-by: lenny <[email protected]>
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
NewBaseResponseWithoutMessage has been removed from go-mod-core-contracts
Issue Number: #556
What is the new behavior?
Now call NewBaseResponse with empty string for the message parameter
Does this PR introduce a breaking change?
Are there any new imports or modules? If so, what are they used for and why?
no
Are there any specific instructions or things that should be known prior to reviewing?
Other information