feat(triggers): Add MQTT Trigger with secure connection options #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenny-goodell
requested review from
rsdmike,
adam-intel,
brian-intel,
jim-wang-intel,
jpwhitemn and
cloudxxx8
Closed
lenny-goodell
force-pushed
the
mqtt-trigger
branch
from
8f310d2 to
32101a8
Compare
|
@judehung @FelixTing please help take a look |
lenny-goodell
force-pushed
the
mqtt-trigger
branch
2 times, most recently
from
fe8e5be to
cf4213e
Compare
lenny-goodell
force-pushed
the
mqtt-trigger
branch
5 times, most recently
from
5885ac0 to
f1c5bfe
Compare
close #454 Signed-off-by: lenny <[email protected]>
lenny-goodell
force-pushed
the
mqtt-trigger
branch
from
f1c5bfe to
0a688f7
Compare
|
recheck |
jpwhitemn
approved these changes
Sep 23, 2020
Yes, I get an email each time I push, but since they are for testing and not real, figured no worries... |
Yes, but I went with |
FelixTing
approved these changes
Sep 23, 2020
brian-intel
approved these changes
Sep 23, 2020
rsdmike
approved these changes
Sep 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
No MQTT trigger currently exists
Issue Number: #454
What is the new behavior?
Now have MQTT Trigger option with ability to connect securely using secrets from secret provider.
Does this PR introduce a breaking change?
Are there any new imports or modules? If so, what are they used for and why?
no
Are there any specific instructions or things that should be known prior to reviewing?
Other information