fix: Make path property required for the Secrets V1 & V2 APIs
#497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes #476 Signed-off-by: lenny <[email protected]>
jim-wang-intel
approved these changes
Sep 18, 2020
jinlinGuan
added a commit
to jinlinGuan/edgex-taf
that referenced
this pull request
Sep 21, 2020
update for edgexfoundry#155 based on the change edgexfoundry/app-functions-sdk-go#497 Signed-off-by: Ginny Guan <[email protected]>
weichou1229
pushed a commit
to weichou1229/edgex-taf
that referenced
this pull request
Nov 2, 2020
update for edgexfoundry#155 based on the change edgexfoundry/app-functions-sdk-go#497 Signed-off-by: Ginny Guan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Secrets API (V1 & V2)
pathproperty is currently optional, but results in error from Vault due to not having write privs for the base path.Issue Number: #476
What is the new behavior?
pathproperty is now required for both V1 & V2 Secrets API.Does this PR introduce a breaking change?
For V1 it results in a n error, so no one could have successfully used Secrets API w/o path set
Are there any new imports or modules? If so, what are they used for and why?
No
Are there any specific instructions or things that should be known prior to reviewing?
Other information