Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Refactor V2 API to use new errors mechanism for go-mo-core-contracts #494

Merged
merged 1 commit into from
Sep 17, 2020

Conversation

lenny-goodell
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

V2 API used old errors definitions from go-mod-core-contracts V2 which no longer exist.

Issue Number: #487

What is the new behavior?

Now uses new errors mechanism from go-mod-core-contracts

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any new imports or modules? If so, what are they used for and why?

no

Are there any specific instructions or things that should be known prior to reviewing?

Other information

@lenny-goodell lenny-goodell changed the title refactor(v2): refactor V2 API to use new errors mechanism for go-mo-core-contracts refactor: refactor V2 API to use new errors mechanism for go-mo-core-contracts Sep 16, 2020
@lenny-goodell lenny-goodell changed the title refactor: refactor V2 API to use new errors mechanism for go-mo-core-contracts refactor: Refactor V2 API to use new errors mechanism for go-mo-core-contracts Sep 16, 2020
@lenny-goodell
Copy link
Member Author

recheck

1 similar comment
@lenny-goodell
Copy link
Member Author

recheck

@bus710
Copy link

bus710 commented Sep 17, 2020

Hi,

Thanks for working on this!

I think the error I am getting is related to this issue:

$ make build
CGO_ENABLED=1 GO111MODULE=on go build -o app-service
go: finding module for package github.com/edgexfoundry/go-mod-core-contracts/clients/urlclient/retry
/root/go/pkg/mod/github.com/edgexfoundry/[email protected]/pkg/urlclient/urlclient.go:24:2: module github.com/edgexfoundry/go-mod-core-contracts@latest found (v0.1.79), but does not contain package github.com/edgexfoundry/go-mod-core-contracts/clients/urlclient/retry
Makefile:6: recipe for target 'build' failed
make: *** [build] Error 1

I want to use a commit version so that I can avoid this issue but it seems like a kind of recurring issue so that I am not sure which commit can be a stable version. Please let me know if you need more information from me to find out about this.

@lenny-goodell lenny-goodell merged commit e35ffeb into edgexfoundry:master Sep 17, 2020
@lenny-goodell
Copy link
Member Author

@bus710 , see my response in Slack.

@lenny-goodell lenny-goodell deleted the v2-errors branch September 17, 2020 18:42
@bus710
Copy link

bus710 commented Sep 17, 2020

Leaving this comment in merged ticket might be a bad idea but just want to leave a follow up.

As guided in the slack channel, I removed all the indirect dependencies in the go.mod of example in app function SDK so that it looks like this:

go 1.15

require (
	github.com/edgexfoundry/app-functions-sdk-go v1.2.0
)

Also, installed ZeroMQ as the gist:

In the simple-filter-xml, I run make and no error found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor V2 APIs to use the new Error Framework in go-mod-core-contracts
3 participants