Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Switch to use Go 1.15 #478

Merged
merged 2 commits into from
Sep 16, 2020
Merged

Conversation

lenny-goodell
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #463

What is the new behavior?

Now uses Go 1.15

Does this PR introduce a breaking change?

  • Yes
  • No

Are there any new imports or modules? If so, what are they used for and why?

no

Are there any specific instructions or things that should be known prior to reviewing?

Other information

@lenny-goodell lenny-goodell linked an issue Sep 10, 2020 that may be closed by this pull request
@lenny-goodell lenny-goodell force-pushed the go1.15 branch 15 times, most recently from 956df1d to 56dd101 Compare September 16, 2020 21:18
closes #463

Signed-off-by: lenny <[email protected]>
Unclear why these didn't fail with Go 1.13.x

Signed-off-by: lenny <[email protected]>
@lenny-goodell
Copy link
Member Author

recheck

@@ -17,7 +17,6 @@
edgeXBuildGoApp (
project: 'app-functions-sdk-go',
semver: true,
goVersion: '1.13',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so we don't specify goVersion in CI pipeline any more?

@lenny-goodell lenny-goodell merged commit 6f19a0c into edgexfoundry:master Sep 16, 2020
@lenny-goodell lenny-goodell deleted the go1.15 branch September 16, 2020 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade SDK to Go 1.15.1
2 participants