feat(sdk): Add background publisher to MessageBus #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenny-goodell
requested changes
Sep 4, 2020
7 tasks
|
@lenny-intel made the changes and force-pushed |
lenny-goodell
previously approved these changes
Sep 4, 2020
|
Looks like ya need to run gofmt on the _test.go file: |
|
@AlexCuse , verify job failed due to internal/trigger/http/rest_test.go needs to be formatted via gofmt |
rsdmike
previously approved these changes
Sep 4, 2020
Creates a channel of provided capacity and attaches to the sdk instance. This channel is then passed to the trigger so that MessageEnvelopes can be pulled off of it and dropped on the queue. Publisher handles formatting the passed message so there is no need to couple using types from go-mod-messaging. Closes: edgexfoundry#462 Signed-off-by: Alex Ullrich <[email protected]>
|
I was so happy I remembered the --signoff that time of course I forgot something else. Just pushed should be good. Have a nice weekend! |
lenny-goodell
approved these changes
Sep 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates a channel of provided capacity and attaches to the sdk instance.
This channel is then passed to the trigger so that MessageEnvelopes can
be pulled off of it and dropped on the queue. Publisher handles
formatting the passed message so there is no need to couple using types
from go-mod-messaging.
Closes: #462
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: 462
What is the new behavior?
Adds a background publisher for MessageBus services
Does this PR introduce a breaking change?
Are there any new imports or modules? If so, what are they used for and why?
No
Are there any specific instructions or things that should be known prior to reviewing?
Other information