fix: Data races detected from Batch function #448 #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After analyzing those data races as listed in #448, there're two variables shall be in atomic operation to avoid data races: 1. batchData 2. timerActive This commit from the batchData [][]byte to atomicBatchData to avoid data race and update timerActive from bool to atomicBool to avoid data race Signed-off-by: Jude Hung <[email protected]>
lenny-goodell
approved these changes
Aug 17, 2020
|
recheck |
|
The first time this job ran -- we saw the same issue with a race condition on the ARM platform so I'm not convinced it has fixed anything. Running it again it passed. I'd like to run the job a couple more times on this PR and monitor the stability of it the pass rate. |
|
@rsdmike if using batch function in the pipeline, the system would run out of memory in couple hours. |
|
@judehung please rebase |
rsdmike
approved these changes
Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After analyzing those data races as listed in #448, there're two
variables shall be in atomic operation to avoid data races:
This commit from the batchData [][]byte to atomicBatchData to avoid data
race and update timerActive from bool to atomicBool to avoid data race
Signed-off-by: Jude Hung [email protected]
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
12 data races are detected from batch function
Issue Number:
#448
What is the new behavior?
Clean up all these data races detected from batch function
Does this PR introduce a breaking change?
Are there any new imports or modules? If so, what are they used for and why?
Are there any specific instructions or things that should be known prior to reviewing?
https://golang.org/doc/articles/race_detector.html#:~:text=A%20data%20race%20occurs%20when,Go%20Memory%20Model%20for%20details.
Other information