feat: Add logging of service version and total startup time #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lenny-intel @rsdmike @charles-knox-intel @ |
lenny-goodell
requested changes
Aug 3, 2020
eno-intel
force-pushed
the
log-startup
branch
2 times, most recently
from
e8146fc to
e491121
Compare
fixes: edgexfoundry#423 Signed-off-by: Enobong Udoko <[email protected]>
lenny-goodell
approved these changes
Aug 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #423
Signed-off-by: Enobong Udoko [email protected]
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The service startup message is currently logged using the message bootstrap handler during the SDK initialize(). This occurs too early as the SDK does additional processing after the bootstrap handlers run.
Issue Number:
#423
What is the new behavior?
Remove use of message bootstrap handler and just need to log the same messages after the call to the SDK Initialize() completes.
Does this PR introduce a breaking change?
Are there any new imports or modules? If so, what are they used for and why?
No
Are there any specific instructions or things that should be known prior to reviewing?
No
Other information