fix: Allow startup duration/interval to be overridden via environement vars #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t vars Startup configuration has been removed since it was not used Env vars are inspected when timer is created so they have impact Signed-off-by: lenny <[email protected]>
lenny-goodell
requested review from
rsdmike,
jim-wang-intel,
charles-knox-intel and
adam-intel
|
LGTM |
lenny-goodell
dismissed stale reviews from charles-knox-intel and jim-wang-intel
via
46d373f
Signed-off-by: lenny <[email protected]>
jim-wang-intel
approved these changes
Jul 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Startup configuration and Env vars have no impact on startup duration/interval
Issue Number: #425
What is the new behavior?
Startup configuration has been removed since it was not used
Env vars are inspected when timer is created so they have impact
Does this PR introduce a breaking change?
Are there any new imports or modules? If so, what are they used for and why?
no since Startup config wasn't actual used.
Are there any specific instructions or things that should be known prior to reviewing?
Other information