refactor: Remove Client monitoring. #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes #385 Signed-off-by: lenny <[email protected]>
|
Why wouldn't this be considered a breaking change? |
@rsdmike , Nope. it is all internal. There are those two packages in /pkg that get removed that should have been in internal since only use by the internal code. Removal of the ClientMonitor setting doesn't impact existing app services. They can leave it in TOML and it will just be ignored. |
charles-knox-intel
approved these changes
Jun 23, 2020
brian-intel
approved these changes
Jun 23, 2020
rsdmike
approved these changes
Jun 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Clients are monitored via polling Consul
Issue Number: #385
What is the new behavior?
No Client monitoring.
Does this PR introduce a breaking change?
Are there any new imports or modules? If so, what are they used for and why?
No
Are there any specific instructions or things that should be known prior to reviewing?
Other information