Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client monitoring uses wrong Context and doesn't exit on ctrl-c #384

Closed
lenny-goodell opened this issue Jun 17, 2020 · 1 comment
Closed
Assignees
Labels
3-high priority denoting release-blocking issues bug Something isn't working hanoi Hanoi release

Comments

@lenny-goodell
Copy link
Member

lenny-goodell commented Jun 17, 2020

Client bootstrap handler is creating new background context for each client monitoring setup, rather than the passed in Context which needs to be used for canceling when ctrl-c pressed.

@lenny-goodell lenny-goodell added 3-high priority denoting release-blocking issues bug Something isn't working hanoi Hanoi release labels Jun 17, 2020
@lenny-goodell
Copy link
Member Author

addressed by #383

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3-high priority denoting release-blocking issues bug Something isn't working hanoi Hanoi release
Projects
None yet
Development

No branches or pull requests

2 participants