Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add pipeline IDs as tags to the metrics collected for each pipeline #1102

Merged

Conversation

lenny-goodell
Copy link
Member

@lenny-goodell lenny-goodell commented Apr 27, 2022

Signed-off-by: Leonard Goodell [email protected]

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/app-functions-sdk-go/blob/main/.github/CONTRIBUTING.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)
    TBD

Testing Instructions

Build App Template with module from this branch
Run from command line with DEBUG logging and verify 8 metrics being reported.
Run ASC with metrics-influxdb using the following command

./app-service-configurable -p=metrics-influxdb | grep "Transformed Metric to"

Verify logs contain metrics with the names from App Templates Config and tags for the pipeline ids

'PipelineMessagesProcessed,service=new-app-service,pipeline=Floats counter-count=14 1651091700525228000' in pipeline 'default-pipeline"

New Dependency Instructions (If applicable)

@lenny-goodell lenny-goodell added this to the Kamakura milestone Apr 27, 2022
@lenny-goodell lenny-goodell added the enhancement New feature or request label Apr 27, 2022
@lenny-goodell lenny-goodell marked this pull request as draft April 27, 2022 21:07
@codecov-commenter
Copy link

Codecov Report

Merging #1102 (2619766) into main (4ae2578) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1102   +/-   ##
=======================================
  Coverage   68.56%   68.56%           
=======================================
  Files          37       37           
  Lines        3022     3022           
=======================================
  Hits         2072     2072           
  Misses        822      822           
  Partials      128      128           
Impacted Files Coverage Δ
internal/app/triggerfactory.go 89.09% <100.00%> (ø)
internal/runtime/runtime.go 78.86% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ae2578...2619766. Read the comment docs.

jim-wang-intel
jim-wang-intel previously approved these changes Apr 27, 2022
@lenny-goodell lenny-goodell marked this pull request as ready for review April 27, 2022 22:42
@lenny-goodell lenny-goodell merged commit cad5e53 into edgexfoundry:main Apr 27, 2022
@lenny-goodell lenny-goodell deleted the register-pipline-id-as-tag branch April 27, 2022 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants