Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added initial SDK level App service metrics #1098

Merged

Conversation

lenny-goodell
Copy link
Member

closes #1085

Signed-off-by: Leonard Goodell [email protected]

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/app-functions-sdk-go/blob/main/.github/CONTRIBUTING.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)
    TBD

Testing Instructions

Run non-secure edgex stack with device virtual
Build and run template app from this branch with DEBUG logging
Verify the logs show 4 different pipeline metrics registered
Verify every 30secs, the logs show 6 metrics reported.

New Dependency Instructions (If applicable)

@lenny-goodell lenny-goodell force-pushed the app-service-common-metrics branch 2 times, most recently from 6ed1c75 to a90322c Compare April 25, 2022 17:26
@lenny-goodell lenny-goodell force-pushed the app-service-common-metrics branch from a90322c to 0a14239 Compare April 25, 2022 19:45
Copy link
Contributor

@jim-wang-intel jim-wang-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except there is unit test failed

Signed-off-by: Leonard Goodell <[email protected]>
jim-wang-intel
jim-wang-intel previously approved these changes Apr 25, 2022
Signed-off-by: Leonard Goodell <[email protected]>
@lenny-goodell lenny-goodell merged commit 3a510b3 into edgexfoundry:main Apr 25, 2022
@lenny-goodell lenny-goodell deleted the app-service-common-metrics branch April 25, 2022 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SDK] Add Service metrics collected by SDK
2 participants