fix(triggers): Return Bad Request Errors Where Appropriate #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AlexCuse , please complete the PR template. i.e. how'd to test it, n/a for docs. |
AlexCuse
force-pushed
the
fix/http-bad-request
branch
2 times, most recently
from
8cd82f5 to
688f51a
Compare
|
This should be good to go @lenny-intel - I think I marked conversations resolved if you want to re-review |
AlexCuse
force-pushed
the
fix/http-bad-request
branch
from
181eaa4 to
d5dcc27
Compare
Requires the trigger to have insight into whether TargetType is byte array or not - exposed this on ServiceBinding as RawInput Fixes edgexfoundry#1019 Signed-off-by: Alex Ullrich <[email protected]>
AlexCuse
force-pushed
the
fix/http-bad-request
branch
from
d5dcc27 to
f5c655a
Compare
Codecov Report
@@ Coverage Diff @@
## main #1022 +/- ##
==========================================
+ Coverage 68.90% 68.91% +0.01%
==========================================
Files 36 36
Lines 2849 2850 +1
==========================================
+ Hits 1963 1964 +1
Misses 777 777
Partials 109 109
Continue to review full report at Codecov.
|
FelixTing
pushed a commit
to FelixTing/app-functions-sdk-go
that referenced
this pull request
Mar 3, 2022
…dry#1022) Requires the trigger to have insight into whether TargetType is byte array or not - exposed this on ServiceBinding as RawInput Fixes edgexfoundry#1019 Signed-off-by: Alex Ullrich <[email protected]> Co-authored-by: Lenny Goodell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires the trigger to have insight into whether TargetType is byte
array or not - exposed this on ServiceBinding as RawInput
Fixes #1019
Signed-off-by: Alex Ullrich [email protected]
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/app-functions-sdk-go/blob/main/.github/CONTRIBUTING.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:describing the break)unit tests sufficient
no docs change
Testing Instructions
New Dependency Instructions (If applicable)