fix(triggers): Log / Config Access #1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After trigger refactoring needs to get logger / config from new location. Fixes edgexfoundry#1020 Signed-off-by: Alex Ullrich <[email protected]>
|
@AlexCuse , please complete the PR template. |
lenny-goodell
approved these changes
Jan 20, 2022
FelixTing
pushed a commit
to FelixTing/app-functions-sdk-go
that referenced
this pull request
Mar 3, 2022
After trigger refactoring needs to get logger / config from new location. Fixes edgexfoundry#1020 Signed-off-by: Alex Ullrich <[email protected]> Co-authored-by: Lenny Goodell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After trigger refactoring needs to get logger / config from new
location.
Fixes #1020
Signed-off-by: Alex Ullrich [email protected]
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/app-functions-sdk-go/blob/main/.github/CONTRIBUTING.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:describing the break)unit tests sufficient
no docs change
Testing Instructions
New Dependency Instructions (If applicable)