Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(triggers): Pass Child Context to Response Handler #1011

Conversation

AlexCuse
Copy link
Contributor

Context used in response handler needs to match context used for
pipeline execution. Fixes #1010.

Signed-off-by: Alex Ullrich [email protected]

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/app-functions-sdk-go/blob/main/.github/CONTRIBUTING.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
    unit tests sufficient
  • I have opened a PR for the related docs change (if not, why?)
    no docs change

Testing Instructions

New Dependency Instructions (If applicable)

Context used in response handler needs to match context used for
pipeline execution.  Fixes edgexfoundry#1010.

Signed-off-by: Alex Ullrich <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Dec 27, 2021

Codecov Report

Merging #1011 (f53d7d6) into main (a4177a0) will decrease coverage by 0.06%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1011      +/-   ##
==========================================
- Coverage   68.96%   68.90%   -0.07%     
==========================================
  Files          36       36              
  Lines        2845     2849       +4     
==========================================
+ Hits         1962     1963       +1     
- Misses        775      777       +2     
- Partials      108      109       +1     
Impacted Files Coverage Δ
internal/app/triggermessageprocessor.go 51.85% <33.33%> (-2.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4177a0...f53d7d6. Read the comment docs.

Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell lenny-goodell merged commit 4ccfd54 into edgexfoundry:main Dec 29, 2021
FelixTing pushed a commit to FelixTing/app-functions-sdk-go that referenced this pull request Mar 3, 2022
)

Context used in response handler needs to match context used for
pipeline execution.  Fixes edgexfoundry#1010.

Signed-off-by: Alex Ullrich <[email protected]>

Co-authored-by: Lenny Goodell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(triggers): pipeline child context not passed to response handler
3 participants