e2e: add a test for checking AKS upstream #939
+348
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miampf
force-pushed
the
miampf/e2e/kata-isolation-cc-test
branch
2 times, most recently
from
b8059ee
to
8fc4293
Compare
|
Note that the boilerplate of manually adding the |
burgerdev
reviewed
Oct 17, 2024
Freax13
reviewed
Oct 18, 2024
miampf
force-pushed
the
miampf/e2e/kata-isolation-cc-test
branch
from
54b0fb1
to
9985321
Compare
Freax13
approved these changes
Oct 22, 2024
miampf
force-pushed
the
miampf/e2e/kata-isolation-cc-test
branch
from
da67e5f
to
80c55ee
Compare
renamed container to testcontainer and log versions
some cleanup and comments respect build tag remove unneccessary if add cleanup
golangci
miampf
force-pushed
the
miampf/e2e/kata-isolation-cc-test
branch
from
80c55ee
to
807b8b3
Compare
miampf
force-pushed
the
miampf/e2e/kata-isolation-cc-test
branch
2 times, most recently
from
7904b8f
to
faad72e
Compare
two jobs indentation :( add forgotten permissions
miampf
force-pushed
the
miampf/e2e/kata-isolation-cc-test
branch
from
faad72e
to
71b3501
Compare
|
Due to |
burgerdev
approved these changes
Oct 24, 2024
| - e2e/aks-runtime/** | ||
|
|
||
| jobs: | ||
| install-software: |
There was a problem hiding this comment.
Could you please leave a pointer here to where these instructions come from?
Comment on lines
+24
to
+29
| echo "Types: deb | ||
| URIs: https://packages.microsoft.com/repos/azure-cli/ | ||
| Suites: ${AZ_DIST} | ||
| Components: main | ||
| Architectures: $(dpkg --print-architecture) | ||
| Signed-by: /etc/apt/keyrings/microsoft.gpg" | sudo tee /etc/apt/sources.list.d/azure-cli.sources |
There was a problem hiding this comment.
Suggested change
| echo "Types: deb | |
| URIs: https://packages.microsoft.com/repos/azure-cli/ | |
| Suites: ${AZ_DIST} | |
| Components: main | |
| Architectures: $(dpkg --print-architecture) | |
| Signed-by: /etc/apt/keyrings/microsoft.gpg" | sudo tee /etc/apt/sources.list.d/azure-cli.sources | |
| sudo tee /etc/apt/sources.list.d/azure-cli.sources <<EOF | |
| Types: deb | |
| URIs: https://packages.microsoft.com/repos/azure-cli/ | |
| Suites: ${AZ_DIST} | |
| Components: main | |
| Architectures: $(dpkg --print-architecture) | |
| Signed-by: /etc/apt/keyrings/microsoft.gpg | |
| EOF |
| WithSpec(kuberesource.PodSpec(). | ||
| WithContainers(kuberesource.Container(). | ||
| WithName(testContainer). | ||
| WithImage("docker.io/bash@sha256:ce062497c248eb1cf4d32927f8c1780cce158d3ed0658c586a5be7308d583cbb"). |
There was a problem hiding this comment.
Let's use quay.io or ghcr.io.
Comment on lines
+112
to
+122
| t.Cleanup(func() { | ||
| if skipUndeploy { | ||
| return | ||
| } | ||
|
|
||
| // delete the deployment | ||
| deletePolicy := metav1.DeletePropagationForeground | ||
| require.NoError(c.Client.AppsV1().Deployments(namespace).Delete(context.Background(), testContainer, metav1.DeleteOptions{ | ||
| PropagationPolicy: &deletePolicy, | ||
| })) | ||
| }) |
There was a problem hiding this comment.
Why not just delete the namespace?
|
|
||
| pods, err := c.Client.CoreV1().Pods(namespace).List(ctx, metav1.ListOptions{}) | ||
| require.NoError(err) | ||
| pod := pods.Items[0] // only one pod was deployed |
There was a problem hiding this comment.
Consider asserting this.
|
|
||
| // KataPolicyGen executes `az confcom katapolicygen --yaml <resourcePath>`. | ||
| func KataPolicyGen(resourcePath string) error { | ||
| return exec.Command("az", "confcom", "katapolicygen", "--yaml", resourcePath).Run() |
There was a problem hiding this comment.
Does this potentially swallow interesting command output?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a test that checks if something in azure upstream is broken by deploying a simple container with the
kata-cc-isolationruntime class. You can view a successful workflow run here.