Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use card template for teams post #925

Merged
merged 11 commits into from
Oct 10, 2024
Merged

Conversation

miampf
Copy link
Contributor

@miampf miampf commented Oct 10, 2024

Rewrite the post_to_teams action to use a JSON template for posting to teams.

@miampf miampf added the no changelog PRs not listed in the release notes label Oct 10, 2024
use old regression test that uses the e2e action
@miampf miampf force-pushed the miampf/ci/rewrite-teams-action branch from 9da3f61 to c9efb67 Compare October 10, 2024 11:18
Copy link
Contributor

@Freax13 Freax13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miampf can you intentionally cause a test failure of one of the e2e so that we can see the generated Teams message?

@miampf
Copy link
Contributor Author

miampf commented Oct 10, 2024

@miampf can you intentionally cause a test failure of one of the e2e so that we can see the generated Teams message?

If it's just for looking at a newly formatted teams message, some (like the last one) were posted in the channel by my test action that used every new feature (see here for the source of that action).

@Freax13
Copy link
Contributor

Freax13 commented Oct 10, 2024

I want to see the message for an e2e failure specifically.

@miampf miampf force-pushed the miampf/ci/rewrite-teams-action branch 2 times, most recently from c3e908a to c9efb67 Compare October 10, 2024 12:32
@miampf
Copy link
Contributor Author

miampf commented Oct 10, 2024

I want to see the message for an e2e failure specifically.

Made the e2e tests fail, look in the channel for a few messages

@miampf miampf merged commit 93bce2f into main Oct 10, 2024
17 of 20 checks passed
@miampf miampf deleted the miampf/ci/rewrite-teams-action branch October 10, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog PRs not listed in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants