Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document aria-own attribute #3

Closed
WW3 opened this issue Mar 9, 2016 · 8 comments
Closed

Document aria-own attribute #3

WW3 opened this issue Mar 9, 2016 · 8 comments

Comments

@WW3
Copy link

WW3 commented Mar 9, 2016

by adding aria-owns to the toggle button with the div's id, screen readers will adjust the virtual buffer as if they were adjutants elements, even if they were not so in the DOM.

Toggle content

random text
another random text
Here is some content that can be be toggled visible or invisible.
@KittyGiraudel
Copy link
Collaborator

Ping @Heydon and @ffoodd to have their opinion on this if they don’t mind sparing a few minutes. :)

@ffoodd
Copy link

ffoodd commented Mar 10, 2016

It could be good as an option, but not as a default. WAI says that [aria-owns] should not be used if there is an actual DOM relationship.

The common use case for a toggle is a direct DOM relationship.

First rule of ARIA: if you can go with native HTML, do so.

It could be an option (like "I want to toggle that far far away thing > true"), but I'm not sure this a going to be used.

Edit: I recommend to avoid it, and to explain a direct DOM relationship is needed. And only if this isn't possible at all, then user should read about [aria-owns].

Do you agree?

@Heydon
Copy link

Heydon commented Mar 10, 2016

And where one did use it, I'm thinking aria-controls becomes redundant?

Also, not tested but I'm wondering if it only works correctly if it is a parent to child relationship, as in Léonie's <ul> / <li> example: http://tink.uk/using-the-aria-owns-attribute/

@ffoodd ffoodd mentioned this issue Mar 10, 2016
@KittyGiraudel
Copy link
Collaborator

I’d rather document it if you guys consider this appropriate than bundle it inside the lib considering how edgy it is.

@Heydon
Copy link

Heydon commented Mar 10, 2016

+1

@ffoodd
Copy link

ffoodd commented Mar 10, 2016

+2 :)

@KittyGiraudel KittyGiraudel changed the title aria-own Document aria-own attribute Mar 13, 2016
@ZoeBijl
Copy link

ZoeBijl commented Apr 12, 2016

There is no need for aria-owns; the relationship is clear from aria-controls.

@WW3 can you elaborate why aria-owns is needed in this context?

@KittyGiraudel
Copy link
Collaborator

I’m closing this for now. I’ll open again if necessary. Feel free to continue discussing. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants
@WW3 @Heydon @KittyGiraudel @ffoodd @ZoeBijl and others