Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Padelpy generating fingerprints in random order #41

Closed
AnjaliSetiya opened this issue Nov 21, 2022 · 2 comments
Closed

Padelpy generating fingerprints in random order #41

AnjaliSetiya opened this issue Nov 21, 2022 · 2 comments

Comments

@AnjaliSetiya
Copy link

It has come to my notice that when we are calculating molecules descriptors of say 5 molecules, the fingerprints generated are in random order.
Screenshot from 2022-11-21 18-11-20
You can see in the image, the order of molecule has changed randomly, can you please tell me ehy is this and what is the work around, I have 10000 molecules, I can't keep a track of any because of this.

@tjkessler
Copy link
Member

Hi @AnjaliSetiya,

If you are using the "padeldescriptor" wrapper function, you need to supply "retainorder=True" to the function. Perhaps it would be more beneficial for me to set its default value to "True" instead of "False"...

Anyways, let me know if this helps!

-T

@AnjaliSetiya
Copy link
Author

Hi @tjkessler
Yes setting "retainorder=True" in the "padeldescriptor" wrapper function helped. And yes it should be default set to True, because it makes more sense to get the fingerprints in the order of the input molecules, it saves a lot of trouble users can encounter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants