Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

padeldescriptor returns no output #26

Closed
naeemmrz opened this issue Jul 3, 2021 · 1 comment
Closed

padeldescriptor returns no output #26

naeemmrz opened this issue Jul 3, 2021 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@naeemmrz
Copy link

naeemmrz commented Jul 3, 2021

Hello,

I've created a .smi file of smiles (1 smile in each row) and I'm running it as:

! pip install padelpy
from padelpy import padeldescriptor
padeldescriptor(mol_dir='ai_ml.smi', d_2d=True, d_3d=True, fingerprints=True, detectaromaticity=True, removesalt=True, retainorder=True, threads=2, d_file='ai_ml_padel_output.csv' )

It exits with no error, however, no output file is generated, any idea what I'm doing wrong? I'm running it on a Jupyter notebook and no errors occurred on installation.

@tjkessler
Copy link
Member

tjkessler commented Jul 8, 2021

Hi @naeemmrz,

I've tested your implementation, and it looks like the argument detectaromaticity=True is causing this issue. According to PaDEL-Descriptor's website, this argument doesn't play nice with other arguments, specifically 3-D descriptor generation: see http://www.yapcwsoft.com/dd/padeldescriptor/, "Known Problems" section.

Removing the detectaromaticity argument (letting it default to False) seems to work and produces an output file:

from padelpy import padeldescriptor

padeldescriptor(
    mol_dir='ai_ml.smi',
    d_2d=True,
    d_3d=True,
    fingerprints=True,
    # detectaromaticity=True,
    removesalt=True,
    retainorder=True,
    threads=2,
    d_file='ai_ml_padel_output.csv'
)

Let me know if this works for you! I'll wait a few days before I close the issue.

-Travis

@tjkessler tjkessler self-assigned this Jul 8, 2021
@tjkessler tjkessler added the bug Something isn't working label Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants