Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Padel Splash Image from Loading #14

Closed
skolmar opened this issue Aug 13, 2020 · 1 comment · Fixed by #27
Closed

Prevent Padel Splash Image from Loading #14

skolmar opened this issue Aug 13, 2020 · 1 comment · Fixed by #27
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested

Comments

@skolmar
Copy link

skolmar commented Aug 13, 2020

Hey,

I love this package, it's working great, except for one inconvenience. When I run "from_smiles()" multiple times, such as on a dataframe with thousands of entries, it reloads the Padel splash image each time it does a calculation, making it impossible to work because it's constantly interrupting whatever window I'm using.

I looked at wrapper.py and can see that there is a "_popen_timeout()" function, which has a call to "popen()". I've tried importing "CREATE_NO_WINDOW" from the "subprocess" module and setting "creation_flags = CREATE_NO_WINDOW" in the "popen()" call, but it doesn't fix the problem.

Is there a simple way to prevent the Padel splash image from loading every computation?

Thanks!

@tjkessler
Copy link
Member

Hi @skolmar,

Thank you for the issue submission, I'm glad you like this package! Unfortunately I do not believe there is a way to suppress the splash screen/image from Python, it is displayed whenever the command line version (or in our specific case, a subprocess call via Python) of PaDEL-Descriptor is executed. From what I can tell, displaying the splash screen is most likely executed from somewhere in PaDEL-Descriptor's source code (PaDEL-Descriptor_src\PaDEL-Descriptor\src\padeldescriptor\PaDELDescriptorApp.java).

I'm going to keep this issue open, I theorize there is a solution (simple or otherwise) and definitely want to implement it into PaDELPy. Perhaps editing PaDEL-Descriptor's source code, suppressing the window from there, and recompiling would fix this 🤔

Best,
Travis

@tjkessler tjkessler self-assigned this Aug 31, 2020
@tjkessler tjkessler added enhancement New feature or request help wanted Extra attention is needed question Further information is requested labels Aug 31, 2020
@tjkessler tjkessler linked a pull request Jul 8, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants