-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up SolvingMicroDSOPs REMARK #30
Comments
I agree that it should not be both a REMARK and an example. If it were shorter and simpler it would be better as an example, but given its complexity probably it is better as a REMARK. I'm not sure there is anything that can really be turned into a reusable standalone library. It's quite possible that there are redundant HARK imports -- please look into that and make a PR to clean that up after verifying that you are right. The other thing that needs to be done with it is to create a Jupyter notebook version that can be used as a teaching tool. Could you put that on your to-do list? |
OK. I think you're saying that the notebook version of this should also be in REMARKs. I'll work on that. It will also be a good test case for a validation script #41 |
Superceded by #103 |
The
SolvingMicroDSOPs
REMARK seems to both:Code/StructEstimation.py
and aCalibration/EstimationParameters.py
try:
block)import
s of the corresponding code from HARK, i.e:https://github.com/econ-ark/REMARK/blob/master/REMARKs/SolvingMicroDSOPs/do_all.py#L68
and...
https://github.com/econ-ark/REMARK/blob/master/REMARKs/SolvingMicroDSOPs/Code/StructEstimation.py#L44
From here, it looks like the imports from HARK are redundant, creating an unnecessary dependence on HARK, and should be removed. @llorracc is that correct?
This relates to HARK #440.
SolvingMicroDSOPs
is an application of HARK that could be moved into anexample/
, or could exist as aREMARK
, but maybe should not be both.If there is some aspect of the
SolvingMicroDSOPs
application that is especially reproducible, I would argue this should be split out into a library classes and methods.The text was updated successfully, but these errors were encountered: