tests in the Lognormal class to make sure mu and sigma have the same … #799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MridulS
reviewed
Aug 19, 2020
| "mu and sigma must be of same length, are %d, %d" % ( | ||
| len(list(self.mu)), len(list(self.sigma)) | ||
| )) | ||
|
|
There was a problem hiding this comment.
what should happen if there are not lists?
good to go.
There was a problem hiding this comment.
Like, if they are scalars? Then they should be converted into length-1 lists, I guess ...
There was a problem hiding this comment.
The internal representation should be numpy arrays, not lists. If the user provides a one-dimensional input, mu and sigma, those should be converted to two 1-element np arrays.
These topics should be moved to a different issue. @MridulS or @sbenthall will create the new issue
llorracc
added
the
Ready-To-Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a couple exception handlers to the Lognormal class to check to make sure that if mu or sigma is a list, they are both lists, and are of the same length.