Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove FashionVictim DEMARK or peg econ-ark dependency to 0.10.2 #77

Closed
sbenthall opened this issue Dec 5, 2019 · 3 comments
Closed

Comments

@sbenthall
Copy link
Contributor

The FashionVictim DEMARK imports code from HARK:

https://github.com/econ-ark/DemARK/blob/master/notebooks/Fashion-Victim-Model.py#L52

After this, it appears to execute the exact same code that is in the Fashion-Victim-Model main() method:
https://github.com/econ-ark/DemARK/blob/master/notebooks/Fashion-Victim-Model.py#L123
https://github.com/econ-ark/HARK/blob/master/HARK/FashionVictim/FashionVictimModel.py#L414

In other words, this DEMARK is just a duplicate of what's in HARK, with some copy-and-pasted code.

FashionVictim is slated to be taken out of the HARK source library and into a HARK examples/ directory.
econ-ark/HARK#440

It has been argued that since FashionVictim is really a kind of tutorial documentation, not material for economics students, it's better for it to be in examples/ than to be a DemARK.

Either:

  • The DemARK should be removed, or,
  • the DemARK econ-ark dependency should be pegged to version 0.10.2 so this DemARK can keep depending on HARK.

If we decide on the latter for some reason, I hope we put some thought into how to design this better to avoid code duplication across repositories.

@llorracc
Copy link
Collaborator

llorracc commented Dec 8, 2019

Let's make FashionVictim an "example" notebook, and remove it from the DemARK.

@llorracc
Copy link
Collaborator

@sbenthall will integrate this with econ-ark/HARK#446

@sbenthall
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants