Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding extra CMAKE_BUILD_TYPE? #33

Open
mathomp4 opened this issue Dec 10, 2020 · 1 comment
Open

Adding extra CMAKE_BUILD_TYPE? #33

mathomp4 opened this issue Dec 10, 2020 · 1 comment

Comments

@mathomp4
Copy link

A query for the "canonical" ecbuild. We (in GEOS) have a fork of ecbuild that we use in our project. Recently I had to patch our fork because I wanted to add a new CMAKE_BUILD_TYPE and it wasn't one of the allowed types by ecbuild:

# fail if build type is not one of the defined ones
if( NOT CMAKE_BUILD_TYPE MATCHES "None" AND
NOT CMAKE_BUILD_TYPE MATCHES "Debug" AND
NOT CMAKE_BUILD_TYPE MATCHES "Bit" AND
NOT CMAKE_BUILD_TYPE MATCHES "Production" AND
NOT CMAKE_BUILD_TYPE MATCHES "Release" AND
NOT CMAKE_BUILD_TYPE MATCHES "RelWithDebInfo" )
ecbuild_critical( "CMAKE_BUILD_TYPE is not recognized. ${_BUILD_TYPE_MSG}" )
endif()

My question is: is there a better way to do this? I added Aggressive as I was adding "aggressive" flags, but say someone wanted to use the more "official" MinSizeRel (which is in the CMake source). As far as I can tell, they couldn't with ecbuild.

@mathomp4
Copy link
Author

@tlmquintino Just a ping. Do you have a good method of a way to "add" additional CMAKE_BUILD_TYPES to an ecbuild system (extra functions, toolchains, etc.)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant