Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make test data server configurable #12

Open
ytremolet opened this issue Oct 14, 2019 · 5 comments
Open

Make test data server configurable #12

ytremolet opened this issue Oct 14, 2019 · 5 comments
Assignees

Comments

@ytremolet
Copy link

The server http://download.ecmwf.org is hardcoded in several places in ecbuild_get_test_data.cmake
It would be better if the server name be made configurable so we can use a server closer to us, add test data, etc...

@oiffrig oiffrig self-assigned this Oct 14, 2019
@tlmquintino
Copy link
Member

This should now be addressed in the develop branch

@tlmquintino
Copy link
Member

A fix has been implemented in 2815760

@tlmquintino
Copy link
Member

Define ECBUILD_DOWNLOAD_BASE_URL as the base for URL construction.

@wdeconinck
Copy link
Member

I have a question..
How do we manage a bundle where test-data may possibly be distributed over multiple test-data servers?
We would have to modify the variable "ECBUILD_DOWNLOAD_BASE_URL" for each subproject.

@tlmquintino
Copy link
Member

I think ECBUILD_DOWNLOAD_BASE_URL should be a default and each project should set its own variable _DOWNLOAD_BASE_URL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants