Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor loop and if structure #25

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

huppd
Copy link
Contributor

@huppd huppd commented Sep 13, 2024

Refactoring loop and if-statement structure to improve OpenACC performance.

@huppd
Copy link
Contributor Author

huppd commented Oct 14, 2024

For our CPU measurements it only had a small impact:
Reference:
MAX AVG
1.937 1.390
1.947 1.391
1.953 1.390

Refactor:
MAX AVG
1.965 1.404
1.968 1.405
1.970 1.406

On the NEC it seems to have even less of an impact:
Reference:
MAX AVG
112.410, 110.948
112.694, 111.067
113.348, 111.763

Refactor:
MAX AVG
112.703, 111.195
112.848, 111.124
113.095, 111.495

For GPU the kernel took before 17.6ms and could be split into two which take 3.59ms and 235μs.

Unfortunately, these are all different comparison, so one cannot compare across platform.
Is that something we could consider to bring back to the main branch?

@huppd huppd marked this pull request as ready for review October 14, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant