-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WebView Support eclipsesource/theia-cloud#296 #57
Conversation
f477c60
to
b7a4e36
Compare
53a62d6
to
449169b
Compare
ff658af
to
b9a011f
Compare
b9a011f
to
03572aa
Compare
* add additional information to AppDefinition for other hostnames that have to be exposed * adapt self-signed certificate generation to use a CA that can be imported as an authority in a browser * add additional wildcard rules when installing the instance ingress * adapt document regeneration documentation to always use latest image * optionally set tls secret name when using paths
03572aa
to
9001b69
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it and it works great 🎉 I have some comments regarding the functionality/naming of one of the fields. Could you take a look at those?
* rename additionalWildcardInstances to allWildcardInstances
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes and clarifications. Looks good to me 👍
This adds a
hosts.paths.tlsSecretName
boolean property which defaults tofalse
(i.e. default behaviour is the same). When set totrue
the same secretName as for the subdomain based ingresses will be used then.ingress.certManagerAnnotations
. This is useful when the certifcates won't be managed by cert-manager at all. Default is stilltrue
.hosts.additionalWildcardInstances
to instances. This is required when the certificates shall be managed via cert-manager, so that all possible paths are already available in the ingress and therefore included in the requests of the cert-manager.Also see eclipse-theia/theia-cloud#298 (also contains testing instructions)
eclipse-theia/theia-cloud#296