You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the current implementation of the build-system I tried to automate the specification of the J2V8 platform, architecture and version in the Maven pom.xml to come closer to a fully automated build / deployment pipeline (see #261)
But it seems that the approach that I took is not really recommended, since maven even explicitely warns about it in each run:
[WARNING] Some problems were encountered while building the effective model for com.eclipsesource.j2v8:j2v8_win32_x64:bundle:${env.J2V8_FULL_VERSION}
[WARNING] 'artifactId' contains an expression but should be a constant. @ com.eclipsesource.j2v8:j2v8_${os}${arch}:${env.J2V8_FULL_VERSION}, C:\code\Github-Fork\J2V8\pom.xml, line 12, column 15
[WARNING] 'version' contains an expression but should be a constant. @ com.eclipsesource.j2v8:j2v8${os}${arch}:${env.J2V8_FULL_VERSION}, C:\code\Github-Fork\J2V8\pom.xml, line 13, column 12
[WARNING] 'build.plugins.plugin.version' for org.apache.maven.plugins:maven-surefire-plugin is missing. @ com.eclipsesource.j2v8:j2v8${os}${arch}:${env.J2V8_FULL_VERSION}, C:\code\Github-Fork\J2V8\pom.xml, line 76, column 15
[WARNING] 'build.plugins.plugin.version' for org.apache.felix:maven-bundle-plugin is missing. @ com.eclipsesource.j2v8:j2v8${os}_${arch}:${env.J2V8_FULL_VERSION}, C:\code\Github-Fork\J2V8\pom.xml, line 88, column 15
[WARNING]
[WARNING] It is highly recommended to fix these problems because they threaten the stability of your build.
[WARNING]
[WARNING] For this reason, future Maven versions might no longer support building such malformed projects.
[WARNING]
For a better solution that still solves the problem I think about parsing the XML of the Maven pom and putting the appropriate values directly into the XML.
I am not sure if grade would have a similar problem, because there I used the same approach (via environment variables) at least for setting the current version number of the J2V8 bundle.
@irbull I have no experience deploying Maven or Gradle bundles to the public repositories, do you have any hints for me about the points above ? Or any other points that should be considered for potentially automating the deployment of J2V8 bundles to the public Maven & Gradle repositories ?
Thanks
The text was updated successfully, but these errors were encountered:
From the deployment perspective I can't really tell if there are pros/cons of having both, since I have no experience hosting either artifacts publicly.
But from the build-system side of things, for Android builds using gradle is so much better than using maven (also there is a dedicated blog post about this topic).
If there would be benefits in moving everything over to gradle and remove the maven parts, or if there are still some legitimate reasons to have both systems in place @irbull would have to answer that.
In the current implementation of the build-system I tried to automate the specification of the J2V8 platform, architecture and version in the Maven
pom.xml
to come closer to a fully automated build / deployment pipeline (see #261)But it seems that the approach that I took is not really recommended, since maven even explicitely warns about it in each run:
For a better solution that still solves the problem I think about parsing the XML of the Maven pom and putting the appropriate values directly into the XML.
I am not sure if grade would have a similar problem, because there I used the same approach (via environment variables) at least for setting the current version number of the J2V8 bundle.
@irbull I have no experience deploying Maven or Gradle bundles to the public repositories, do you have any hints for me about the points above ? Or any other points that should be considered for potentially automating the deployment of J2V8 bundles to the public Maven & Gradle repositories ?
Thanks
The text was updated successfully, but these errors were encountered: