Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Feature Branding #1575

Open
cdietrich opened this issue Nov 4, 2019 · 2 comments
Open

Fix Feature Branding #1575

cdietrich opened this issue Nov 4, 2019 · 2 comments

Comments

@cdietrich
Copy link
Member

cdietrich commented Nov 4, 2019

According to this report our Feature Branding is incomplete

https://download.eclipse.org/oomph/archive/reports/download.eclipse.org/staging/2019-12/index.html

i am not sure how to fix that.

  • we dont have n branding plugins for n features
  • the branding plugins contain all kind of stuff in about.ini and about.properties
  • the feature provider is "Eclipse Xtext" am not sure what is used to "group" in the about dialog. (Xtend is under that point too but i guess that is ok)
  • not all features are part of catgory.xmls but i am not sure how @merks scans for available features. (we have a lot of this feature contains that other or two)
@cdietrich
Copy link
Member Author

see also eclipse/mwe#115

@merks
Copy link
Contributor

merks commented Nov 4, 2019

Don't worry so much about the branding. This just means your features won't show up group in the About dialog under the associated images in that dialog.

But note that you can reuse any plugin via the plugin="x" in the element of the feature.xml; it should be some bundle that will be installed when the feature is installed.

If you have proper licenses and signatures then I'm very happy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants