Skip to content
This repository has been archived by the owner on May 7, 2020. It is now read-only.

[BasicUI] Slider knob not showing in BasicUI on Microsoft Edge #2882

Closed
FusedHe3 opened this issue Jan 23, 2017 · 6 comments
Closed

[BasicUI] Slider knob not showing in BasicUI on Microsoft Edge #2882

FusedHe3 opened this issue Jan 23, 2017 · 6 comments

Comments

@FusedHe3
Copy link

Hi everybody,

I know this isn't a major issue, but I noticed that the slider knob is missing when using the BasicUI in Microsoft Edge. This makes adjusting the slider a bit tricky.
Edge:
snip_slider
IE:
snip_slider12

Using the F12 DOM Explorer and comparing the CSS styling between Edge and Internet Explorer, I discovered that the height of .mdl-slider.is-upgraded is set to 2px in Edge and due to an override from _:-ms-input-placeholder, :root .mdl-slider.mdl-slider.is-upgraded it is set to 32px in IE. As this override doesn't happen in Edge, the height stays at 2px and the knob isn't showing.

Edge:
snip_slider2

IE:
snip_slider23
snip_slider4

Setting the height to 32px in Edge fixes the problem.

I don't know if this is an issue inherent to Google Material Design or if there is a simple fix. But it would be nice to see the slider working in Edge to, as I use it as my primary browser on all my devices.

Thanks!

@kaikreuzer
Copy link
Contributor

@resetnow, could you please have a look?

@FusedHe3 FusedHe3 changed the title Slider knob not showing in BasicUI on Microsoft Edge [BasicUI] Slider knob not showing in BasicUI on Microsoft Edge Jan 24, 2017
@vlad-ivanov-name
Copy link
Contributor

It looks like this particular problem is present upstream — I tried updating MDL to a latest version and it looked even worse. Also, even with the width property applied the knob is off by 10-20 pixels to the left. I'll try to fix it upstream and then backport the fix here — I assume in this case we won't have to deal with the legal approval process.

@vlad-ivanov-name
Copy link
Contributor

Relevant issue: google/material-design-lite#1625

@FusedHe3
Copy link
Author

Great, thanks!

@vlad-ivanov-name
Copy link
Contributor

vlad-ivanov-name commented Jan 30, 2017

It seems Google's MDL is in limited support mode — it may not be possible to push a full fix there. So I have opened #2932 with a CSS hack for sliders, it doesn't fix them completely but at least the knob is visible and can be moved.

@FusedHe3
Copy link
Author

FusedHe3 commented Feb 2, 2017

Thanks @resetnow! At least it's working now :D

@FusedHe3 FusedHe3 closed this as completed Feb 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants