Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for pnpm #368

Open
idleberg opened this issue Nov 19, 2021 · 2 comments
Open

Support for pnpm #368

idleberg opened this issue Nov 19, 2021 · 2 comments
Labels
cli Component: cli priority:low question Further information is requested

Comments

@idleberg
Copy link

idleberg commented Nov 19, 2021

ovsx publish does not explicitly support the pnpm package manager. To my surprise, using the --yarn flag will publish the extension just fine.

Questions:

  1. is using the --yarn flag for packages with pnpm lockfiles intentional (or coincidence?)
  2. should the flag be renamed to something more generic?
  3. should there be a second flag for pnpm in a future release?
  4. will the above still be relevant, once corepack is stable and ships with npm?
@spoenemann spoenemann added cli Component: cli question Further information is requested labels Nov 22, 2021
@spoenemann
Copy link
Member

We just pass that flag to vsce, which is used behind the scenes to package extensions. If vsce adds a dedicated flag for pnpm or changes the --yarn flag, we should adapt ovsx as well.

@idleberg
Copy link
Author

Related but unresolved vsce issue:

microsoft/vscode-vsce#421

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Component: cli priority:low question Further information is requested
Projects
Status: Todo
Development

No branches or pull requests

3 participants