Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use MP-CP instead of AsyncInvocationInterceptor? #237

Open
FroMage opened this issue Dec 3, 2019 · 1 comment
Open

Use MP-CP instead of AsyncInvocationInterceptor? #237

FroMage opened this issue Dec 3, 2019 · 1 comment

Comments

@FroMage
Copy link

FroMage commented Dec 3, 2019

I'm wondering if AsyncInvocationInterceptor has uses-cases besides context propagation? If it doesn't, we should probably deprecate it in favour of integration with MP-Context-Propagation, no?

What do users do with those interceptors?

@andymc12
Copy link
Contributor

andymc12 commented Dec 5, 2019

In general, I am +1 for this.

The primary use case for AsyncInvocationInterceptors are for context propagation. For most scenarios, I think MP Context Propagation could replace the interceptors. But MP Context Propagation won't propagate all thread locals will it? I'm concerned that some users would lose the ability for propagating some "custom" thread locals, but I'm not an expert in MP CP, so maybe this is not a valid concern?

@jclingan jclingan added this to the Future milestone Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants