Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to coordinator endpoints from the LRAClent API #42

Open
mmusgrov opened this issue Nov 13, 2018 · 4 comments
Open

Remove references to coordinator endpoints from the LRAClent API #42

mmusgrov opened this issue Nov 13, 2018 · 4 comments
Milestone

Comments

@mmusgrov
Copy link
Contributor

The ClientAPI java doc and Java constants imply that there must be an LRA coordinator endpoint somewhere in the system (for example LRA_COORDINATOR_HOST_KEY and LRA_COORDINATOR_PORT_KEY). The implementation of this specification should be flexible enough to not require coordinators to be listening on network endpoints. Such references should be removed from LRAClient.

@xstefank
Copy link
Member

I will create a PR for this issue

@mmusgrov
Copy link
Contributor Author

@xstefank don't we need a resolution to #62 before removing this?

@xstefank
Copy link
Member

issue #62 will cover conversion to MP config definition of the properties, i.e. how the properties can be defined. In this one I will just update the property names.

@mmusgrov
Copy link
Contributor Author

mmusgrov commented Feb 6, 2019

@xstefank When you have the smallrye implementation ready I think we can merge this PR

@mmusgrov mmusgrov modified the milestones: 1.0, 1.x Mar 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants