Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More tests for @LRA defined at the class level are needed #359

Open
marcosgopen opened this issue May 27, 2022 · 0 comments
Open

More tests for @LRA defined at the class level are needed #359

marcosgopen opened this issue May 27, 2022 · 0 comments
Assignees
Milestone

Comments

@marcosgopen
Copy link

The participant used for testing the @LRA annotation defined at the class level only defines LRA.Type.SUPPORTS for the Type attribute:

@Path(LraResource.LRA_RESOURCE_PATH)
@LRA(value = LRA.Type.SUPPORTS, end = false)
public class LraResource extends ResourceParent
...

So, for example, if there is no incoming LRA context then the expected behaviour around starting LRAs is not validated.

We should add TCK tests that verify the correct behaviour with other values of the LRA.Type element (https://github.com/eclipse/microprofile-lra/blob/master/api/src/main/java/org/eclipse/microprofile/lra/annotation/ws/rs/LRA.java#L166).

As well as the extra tests the specification text that describes @LRA annotation behaviour defined at the class level should be enhanced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants