Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Produce Release Candidate #169

Closed
rdebusscher opened this issue Jun 19, 2019 · 10 comments
Closed

Produce Release Candidate #169

rdebusscher opened this issue Jun 19, 2019 · 10 comments
Assignees
Milestone

Comments

@rdebusscher
Copy link
Member

We need to have a RC available which can be tested out/used by the community during a couple of months before we can go final.

@xstefank
Copy link
Member

For me personally, I would only like to only add some TCK tests which can be done after RC if I'm not mistaken. The API is stable enough already. Minor tweaks if something is hit after RC should also be possible. Other specifications took between 3-5 months in RCs so I'm a big +1 on this!

@tomjenkinson
Copy link
Contributor

tomjenkinson commented Jun 20, 2019

It does look like spec text changes and TCK tests rather than new functionality: https://github.com/eclipse/microprofile-lra/issues?q=is%3Aopen+is%3Aissue+milestone%3A1.0 is the scope of what is left. An RC would be great!

@mmusgrov mmusgrov self-assigned this Jun 23, 2019
@mmusgrov mmusgrov added this to the 1.0 milestone Jun 23, 2019
@mmusgrov
Copy link
Contributor

FYI the CQs for the project are:

[INFO] +- javax.ws.rs:javax.ws.rs-api:jar:2.0.1:provided
https://dev.eclipse.org/ipzilla/show_bug.cgi?id=20308
[INFO] +- javax.enterprise:cdi-api:jar:1.2:compile
https://dev.eclipse.org/ipzilla/show_bug.cgi?id=20310
[INFO] +- software.amazon.awssdk:s3:jar:2.0.0-preview-5:compile
[CQ19892] awssdk Version 2.5.49
https://dev.eclipse.org/ipzilla/show_bug.cgi?id=20309
[INFO] +- javax.json:javax.json-api:jar:1.0:provided [INFO] +- org.eclipse.microprofile.config:microprofile-config-api:jar:1.3:provided
https://dev.eclipse.org/ipzilla/show_bug.cgi?id=20311
[INFO] +- junit:junit:jar:4.12:compile
https://dev.eclipse.org/ipzilla/show_bug.cgi?id=20312
[INFO] +- org.jboss.arquillian.junit:arquillian-junit-container:jar:1.4.1.Final:compile
https://dev.eclipse.org/ipzilla/show_bug.cgi?id=20313

@mmusgrov
Copy link
Contributor

I will have a go at creating the Jenkins job for the release when we have decided what to do with the outstanding API and spec PRs.

@rdebusscher
Copy link
Member Author

@mmusgrov the amazon aws dependency is only required at runtime? At least not for compiling the TCK project.

Is Amazon AWS S3 required for running the TCK, I don't see anything in the TCK readme.

@mmusgrov
Copy link
Contributor

mmusgrov commented Jun 30, 2019

Thanks @rdebusscher - I have withdrawn the aws s3 cq and will remove the maven dependency from the tck pom when I submit the PR.

@mmusgrov
Copy link
Contributor

mmusgrov commented Jul 6, 2019

FYI: The CQ for the arquilian junit dependency (https://dev.eclipse.org/ipzilla/show_bug.cgi?id=20313) is still awaiting PMC approval.

Note that there is already an approved CQ for arquilian testng so we could easily migrate the TCK from junit to testng if it becomes an issue.

@mmusgrov
Copy link
Contributor

mmusgrov commented Jul 8, 2019

Martin pointed out that the approved CQ 13755 (https://dev.eclipse.org/ipzilla/show_bug.cgi?id=13755) includes the arquillian junit dependency. I have withdrawn https://dev.eclipse.org/ipzilla/show_bug.cgi?id=20313 and created a piggyback CQ for out test dependency:

https://dev.eclipse.org/ipzilla/show_bug.cgi?id=20328

@mmusgrov
Copy link
Contributor

I don' think I needed a CQ for a "Works With Dependency" (CQ 13755) so I have withdrawn the piggyback CQ 20328 for the test dependencies.

This means that we now have all the CQ approvals and we just need the final review of PR #176

@mmusgrov
Copy link
Contributor

RC 1 is tagged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants