Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec: Indicate that LRA id MUST be of type URI #163

Closed
rdebusscher opened this issue Jun 9, 2019 · 3 comments
Closed

Spec: Indicate that LRA id MUST be of type URI #163

rdebusscher opened this issue Jun 9, 2019 · 3 comments
Assignees
Milestone

Comments

@rdebusscher
Copy link
Member

After the implementation of #35, but internal the already before the implementation of this, LRA id MUST be of type URI.

So we need to indicate this requirement in the spec.
We should change all examples in the spec where we use @HeaderParam(LRA_HTTP_CONTEXT_HEADER) and @HeaderParam(LRA_HTTP_PARENT_CONTEXT_HEADER) to URI to be consistent.

We can indicate in a note that String will work due to the conversion within JAX-RS, but only when the method is a JAX-RS method.

@rdebusscher rdebusscher added this to the 1.0 milestone Jun 9, 2019
@rdebusscher
Copy link
Member Author

The recovery ID is also indicated as a URI in the JavaDoc. We can mention this also in the Spec text.

@rdebusscher
Copy link
Member Author

Update the TCK for using URI instead of String

@mmusgrov
Copy link
Contributor

#165 resolves this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants