Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specification for @Asynchronous assumes existence of security/naming context #514

Closed
Ladicek opened this issue Feb 26, 2020 · 3 comments · Fixed by #552
Closed

specification for @Asynchronous assumes existence of security/naming context #514

Ladicek opened this issue Feb 26, 2020 · 3 comments · Fixed by #552
Assignees
Milestone

Comments

@Ladicek
Copy link
Contributor

Ladicek commented Feb 26, 2020

The very beginning of the specification text for @Asynchronous says:

Asynchronous means the execution of the client request will be on a separate thread.
This thread should have the correct security context or naming context associated with it.

However, MicroProfile doesn't know anything about security context or naming context. These are purely EE concerns.

We should separate that sentence into a dedicated section somewhere near the end of the specification, similarly to other MP specifications that also deal with EE concerns (such as MP JWT: https://download.eclipse.org/microprofile/microprofile-jwt-auth-1.1.1/microprofile-jwt-auth-spec.html#_recommendations_for_optional_container_integration). Also, we should make the sentence more concrete. Something like:

Recommendations for Optional Container Integration

This section describes the expected behaviors when the implementation runs in a Java EE container.

Asynchronous

Threads that are servicing @Asynchronous invocations should, for the duration of the invocation, have the correct security context and naming context associated.

@Ladicek
Copy link
Contributor Author

Ladicek commented Mar 3, 2020

We should also add some TCK tests for this, in an optional way.

@Azquelt Azquelt added this to the 3.0 milestone Mar 3, 2020
@Emily-Jiang
Copy link
Member

related to #326

@Ladicek Ladicek self-assigned this Jun 3, 2020
@Ladicek
Copy link
Contributor Author

Ladicek commented Jun 3, 2020

Submitted a PR. I didn't add a TCK test, because 1. it would have to be a separate TCK module, 2. even if I did that, I don't know how I would test this :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants