add support for Map injection #750
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
Emily-Jiang
reviewed
Aug 31, 2022
| @@ -121,6 +121,11 @@ public class InjectedConfigUsageSample { | |||
| @ConfigProperty(name="myprj.some.supplier.timeout", defaultValue="100") | |||
| private java.util.function.Supplier<Long> timeout; | |||
|
|
|||
| //Injects a Map to resolve multiple configuration parameters under the same configuration key. | |||
There was a problem hiding this comment.
For the Map injection, what types for Key, Value do you propose to support? We need to clarify that.
otaviojava
reviewed
Sep 3, 2022
| //Injects a Map to resolve multiple configuration parameters under the same configuration key. | ||
| @Inject | ||
| @ConfigProperty(name = "myprj.some.reasons", defaultValue = "200=OK;201=Created") | ||
| private java.util.Map<Integer, String> reasons; |
There was a problem hiding this comment.
Suggested change
| private java.util.Map<Integer, String> reasons; | |
| private java.util.Map<String, String> reasons; |
Once we're talking about configuration, I believe the key must be a String
There was a problem hiding this comment.
I tend to agree to narrow down to Map<String, String>. Otherwise, it will be overwhelming with the tests and it might have more issues to deal with regarding conversion errors.
radcortez
requested changes
Sep 6, 2022
| @@ -121,6 +121,11 @@ public class InjectedConfigUsageSample { | |||
| @ConfigProperty(name="myprj.some.supplier.timeout", defaultValue="100") | |||
| private java.util.function.Supplier<Long> timeout; | |||
|
|
|||
| //Injects a Map to resolve multiple configuration parameters under the same configuration key. | |||
| @Inject | |||
| @ConfigProperty(name = "myprj.some.reasons", defaultValue = "200=OK;201=Created") | |||
There was a problem hiding this comment.
The specification must define how the map properties are parsed (both on a source and in the defaults).
| public class MapConverterBean { | ||
|
|
||
| @Inject | ||
| @ConfigProperty(name = "tck.config.test.javaconfig.converter.map.string.string") |
There was a problem hiding this comment.
What if we call the programmatic API? What happens?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #562