-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In Maven <configuration>, all known XML elements from schema are suggested as completion #612
Comments
This behaviour is because of use of <xs:element minOccurs="0" name="configuration">
<xs:complexType>
<xs:sequence>
<xs:any minOccurs="0" maxOccurs="unbounded" processContents="skip"/>
</xs:sequence>
</xs:complexType>
</xs:element>
If I understand your need, you want to manage completion for configuration in your maven lsp4xml extension? If it that I agree and we should give the capability to override the default behaviour of XML Schema completion. |
Yes
It seems to me that |
For validation yes (you can add any XML content), but for completion we decide to provide something for this issue In other words, some user want to have this completion behaviour, but I agree with you, if you write an extension and you wish to override this behaviour, it's annoying. So we need to give the capability for an extension to override this default XML Schema behaviour. |
You mentioned on that comment that user should use
Why aren't they using
It seems to me that the schema has everything necessary, the LS shouldn't facilitate the work with bad schemas if as a consequence it reduces the quality of the work with good schemas (like Maven one). |
WTP XML isn't always a good reference ;) But if LemMinX is tweaked so that it would only show the "project" element as additional items in configuration block, it would already be nice and probably enough. |
To be honnest with you, I have not a strong opinion about the proper behavior about @fbricon what do you think about that? |
let's compare with other editors first |
suggested as completion Fixes eclipse-lemminx#612 Signed-off-by: azerr <[email protected]>
suggested as completion Fixes #612 Signed-off-by: azerr <[email protected]>
In Maven , all known XML elements from schema are suggested as completion.
This is typically not desired as the Maven extension can provide higher quality proposals here and the extra items are useless and generate noise reducing the usability.
The text was updated successfully, but these errors were encountered: