Upgrade maven from 3.6.3 to 3.9.6. #1585
Merged
+8
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motlin
commented
May 18, 2024
| @@ -19,7 +19,7 @@ jobs: | |||
| - name: Git Checkout | |||
| uses: actions/checkout@v4 | |||
| - name: Set Maven Wrapper | |||
| run: mvn -N wrapper:wrapper -Dmaven=3.6.3 | |||
| run: mvn --non-recursive wrapper:wrapper -Dmaven=3.9.6 | |||
There was a problem hiding this comment.
I replaced -N with --non-recursive just because I didn't know what it was and figured I'd spell it out so I don't have to look it up again. The main thing I wanted to do is use a modern version of maven that supports colors.
|
Added @nikhilnanivadekar for review to make sure there will be no issues with release using later version of Maven. |
donraab
approved these changes
May 20, 2024
There was a problem hiding this comment.
LGTM. Will wait for @nikhilnanivadekar to approve as well so he is aware of the upgrade before we do next release.
|
I checked with @nikhilnanivadekar and he is fine with the upgrade @motlin. I will merge now. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.