Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port redirect only option is "Yes" #17972

Closed
l0rd opened this issue Sep 25, 2020 · 6 comments
Closed

Port redirect only option is "Yes" #17972

l0rd opened this issue Sep 25, 2020 · 6 comments
Labels
area/plugins kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system.

Comments

@l0rd
Copy link
Contributor

l0rd commented Sep 25, 2020

Describe the bug

image

We should have a "No" option as well and the message could be improved too: "...but this port is not in the workspace endpoints. Would you like to expose it as an external ingress and make it accessible from your browser?".
@l0rd l0rd added the kind/bug Outline of a bug - must adhere to the bug report template. label Sep 25, 2020
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Sep 25, 2020
@l0rd l0rd added severity/P2 Has a minor but important impact to the usage or development of the system. area/plugin-port Issues related to the port plugin and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Sep 25, 2020
@l0rd l0rd mentioned this issue Sep 29, 2020
Closed
16 tasks
@tsmaeder
Copy link
Contributor

And a "never ask me again" would be handy, as well. When developing Che-in-Che, it's really annoying to have to click it away each time I start the back end process.

@benoitf
Copy link
Contributor

benoitf commented Sep 29, 2020

I think there are another issue to have the same design that is also used in VS Code Online codespaces now

TL;DR a widget instead of tons of annoying dialogs/popups

@l0rd
Copy link
Contributor Author

l0rd commented Sep 29, 2020

We should never see this popup: when an endpoint is defined as public: false we should NOT ask if the user wants to redirect. That's one of the issues of the epic.

@benoitf
Copy link
Contributor

benoitf commented Sep 29, 2020

@l0rd I think if there is no widget replacement we can't remove it.
Because, else you kill the other flow: if you start from scratch by cloning a nodejs express example that will listen on the port 3000 you want to have this example working and you don't want to add a new endpoint and restart your workspace at this point.

I agree on the popup removal but by having a widget replacement else the user will be stuck.

@l0rd
Copy link
Contributor Author

l0rd commented Sep 30, 2020

@l0rd I think if there is no widget replacement we can't remove it.
Because, else you kill the other flow: if you start from scratch by cloning a nodejs express example that will listen on the port 3000 you want to have this example working and you don't want to add a new endpoint and restart your workspace at this point.

I agree on the popup removal but by having a widget replacement else the user will be stuck.

@benoitf I am not sure we are talking about the same thing. I have created a separate issue for that #17993

I think there are another issue to have the same design that is also used in VS Code Online codespaces now

TL;DR a widget instead of tons of annoying dialogs/popups

If there is another issue let's close this one.

@azatsarynnyy azatsarynnyy added area/plugins and removed area/plugin-port Issues related to the port plugin labels Sep 30, 2020
@azatsarynnyy
Copy link
Member

moving to area/plugins as the related functionality is in Ports Plugin

@benoitf benoitf mentioned this issue Oct 10, 2020
Merged
benoitf added a commit to benoitf/che-theia that referenced this issue Oct 12, 2020
@benoitf
Introduce port plug-in widget
ce9f3aa 
 - move modal dialogs to classic notification
 - add missing no option in redirect dialog
 - handle internal endpoints (private ports)
 - Add ports widget in addition to dialog popup of port plug-in
 - display public and private ports
 - allow to open in a new tab or preview url
 - filtering plugin's endpoints (default = true)

Fixes eclipse-che/che#17972
Fixes eclipse-che/che#17993

Change-Id: I5dd802ea51d6a10be525a169e03632f37480a5ac
Signed-off-by: Florent Benoit <[email protected]>
benoitf added a commit to benoitf/che-theia that referenced this issue Oct 12, 2020
@benoitf
Introduce port plug-in widget
eae3a47 
 - move modal dialogs to classic notification
 - add missing no option in redirect dialog
 - handle internal endpoints (private ports)
 - Add ports widget in addition to dialog popup of port plug-in
 - display public and private ports
 - allow to open in a new tab or preview url
 - filtering plugin's endpoints (default = true)

Fixes eclipse-che/che#17972
Fixes eclipse-che/che#17993

Change-Id: I5dd802ea51d6a10be525a169e03632f37480a5ac
Signed-off-by: Florent Benoit <[email protected]>
benoitf added a commit to benoitf/che-theia that referenced this issue Oct 19, 2020
@benoitf
Introduce port plug-in widget
f4acd6a 
 - move modal dialogs to classic notification
 - add missing no option in redirect dialog
 - handle internal endpoints (private ports)
 - Add ports widget in addition to dialog popup of port plug-in
 - display public and private ports
 - allow to open in a new tab or preview url
 - filtering plugin's endpoints (default = true)

Fixes eclipse-che/che#17972
Fixes eclipse-che/che#17993

Change-Id: I5dd802ea51d6a10be525a169e03632f37480a5ac
Signed-off-by: Florent Benoit <[email protected]>
benoitf added a commit to benoitf/che-theia that referenced this issue Oct 23, 2020
@benoitf
Introduce port plug-in widget
2ab335b 
 - move modal dialogs to classic notification
 - add missing no option in redirect dialog
 - handle internal endpoints (private ports)
 - Add ports widget in addition to dialog popup of port plug-in
 - display public and private ports
 - allow to open in a new tab or preview url
 - filtering plugin's endpoints (default = true)

Fixes eclipse-che/che#17972
Fixes eclipse-che/che#17993

Change-Id: I5dd802ea51d6a10be525a169e03632f37480a5ac
Signed-off-by: Florent Benoit <[email protected]>
benoitf added a commit to benoitf/che-theia that referenced this issue Oct 26, 2020
@benoitf
Introduce port plug-in widget
fb09bfb 
 - move modal dialogs to classic notification
 - add missing no option in redirect dialog
 - handle internal endpoints (private ports)
 - Add ports widget in addition to dialog popup of port plug-in
 - display public and private ports
 - allow to open in a new tab or preview url
 - filtering plugin's endpoints (default = true)

Fixes eclipse-che/che#17972
Fixes eclipse-che/che#17993

Change-Id: I5dd802ea51d6a10be525a169e03632f37480a5ac
Signed-off-by: Florent Benoit <[email protected]>
benoitf added a commit to benoitf/che-theia that referenced this issue Oct 27, 2020
@benoitf
Introduce port plug-in widget
20f82ee 
 - move modal dialogs to classic notification
 - add missing no option in redirect dialog
 - handle internal endpoints (private ports)
 - Add ports widget in addition to dialog popup of port plug-in
 - display public and private ports
 - allow to open in a new tab or preview url
 - filtering plugin's endpoints (default = true)

Fixes eclipse-che/che#17972
Fixes eclipse-che/che#17993

Change-Id: I5dd802ea51d6a10be525a169e03632f37480a5ac
Signed-off-by: Florent Benoit <[email protected]>
benoitf added a commit to benoitf/che-theia that referenced this issue Nov 4, 2020
@benoitf
Introduce port plug-in widget
3cdfc8e 
 - move modal dialogs to classic notification
 - add missing no option in redirect dialog
 - handle internal endpoints (private ports)
 - Add ports widget in addition to dialog popup of port plug-in
 - display public and private ports
 - allow to open in a new tab or preview url
 - filtering plugin's endpoints (default = true)

Fixes eclipse-che/che#17972
Fixes eclipse-che/che#17993

Change-Id: I5dd802ea51d6a10be525a169e03632f37480a5ac
Signed-off-by: Florent Benoit <[email protected]>
monaka pushed a commit to PizzaFactory/che-theia that referenced this issue Nov 4, 2020
@benoitf @monaka
Introduce port plug-in widget
6533284 
 - move modal dialogs to classic notification
 - add missing no option in redirect dialog
 - handle internal endpoints (private ports)
 - Add ports widget in addition to dialog popup of port plug-in
 - display public and private ports
 - allow to open in a new tab or preview url
 - filtering plugin's endpoints (default = true)

Fixes eclipse-che/che#17972
Fixes eclipse-che/che#17993

Change-Id: I5dd802ea51d6a10be525a169e03632f37480a5ac
Signed-off-by: Florent Benoit <[email protected]>
monaka pushed a commit to PizzaFactory/che-theia that referenced this issue Nov 5, 2020
@benoitf @monaka
Introduce port plug-in widget
15176e2 
 - move modal dialogs to classic notification
 - add missing no option in redirect dialog
 - handle internal endpoints (private ports)
 - Add ports widget in addition to dialog popup of port plug-in
 - display public and private ports
 - allow to open in a new tab or preview url
 - filtering plugin's endpoints (default = true)

Fixes eclipse-che/che#17972
Fixes eclipse-che/che#17993

Change-Id: I5dd802ea51d6a10be525a169e03632f37480a5ac
Signed-off-by: Florent Benoit <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/plugins kind/bug Outline of a bug - must adhere to the bug report template. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@benoitf @l0rd @azatsarynnyy @tsmaeder @che-bot