#16476 - push new plugins into master branch... #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y.z release Signed-off-by: nickboldt <[email protected]>
nickboldt
requested review from
benoitf,
ericwill,
vinokurig and
vitaliy-guliy
as code owners
17 tasks
mkuznyetsov
approved these changes
Apr 28, 2020
|
@mkuznyetsov please re-review after I refactored a bunch of stuff to make the code more reused (less boilerplate) |
Change-Id: I14ab368477090daf955f160c2ec721c1e9114e41 Signed-off-by: nickboldt <[email protected]>
…ON in commitChangeOrCreatePR() when only pushing plugins to master (.z release) Change-Id: If501fbcfd55173b54f318b4e880d49b77f4d8107 Signed-off-by: nickboldt <[email protected]> fix shellcheck issues Change-Id: I87b3af0077d11e022f50061559e47434fb26dae9 Signed-off-by: nickboldt <[email protected]>
|
@mkuznyetsov said: "yeah, I looked through your refactor, looks alright, except for a bit odd styling of naming variables " |
monaka
pushed a commit
to PizzaFactory/che-plugin-registry
that referenced
this pull request
May 3, 2020
* #16476 - push new plugins into master branch too, if we're doing a 7.y.z release Signed-off-by: nickboldt <[email protected]> * remove boilerplate code into method for reuse Change-Id: I14ab368477090daf955f160c2ec721c1e9114e41 Signed-off-by: nickboldt <[email protected]> * fixup pr branch names, message when NOCOMMIT=1, and set correct VERSION in commitChangeOrCreatePR() when only pushing plugins to master (.z release) Change-Id: If501fbcfd55173b54f318b4e880d49b77f4d8107 Signed-off-by: nickboldt <[email protected]> fix shellcheck issues Change-Id: I87b3af0077d11e022f50061559e47434fb26dae9 Signed-off-by: nickboldt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#16476 - push new plugins into master branch too, if we're doing a 7.y.z release
Signed-off-by: nickboldt [email protected]